On Tue, Apr 16, 2013 at 01:12:21PM +1000, Dave Airlie wrote:
On Mon, Apr 15, 2013 at 11:37 PM, Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com wrote:
Property blob objects need to be destroyed when cleaning up to avoid memory leaks. Go through the list of all blobs in the drm_mode_config_cleanup() function and destroy them.
The drm_mode_config_cleanup() function needs to be moved after the drm_property_destroy_blob() declaration. Move drm_mode_config_init() as well to keep the functions together.
Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com Reviewed-by: Daniel Vetter daniel.vetter@ffwll.ch
I've applied this one, the other two I don't mind, but I'm not sure they aren't a bit restrictive in the generic code,
Patch 2 is just for the crtc helpers, and matches what we've just done in the i915 code. I think it fits in with the general design of the crtc helpers.
Patch 1 matches a check in the intel code, too. So since applications can't really know whether a flip to a different pixel format works I don't think that capability is useful at all. And at least for i915 it's just broken ;-) On patch 1 itself though: Just checking fb->pixel_format should be good enough. -Daniel