Hi Tomi, thanks for reviewing the patch.
On mar 28-04-2020 12:49:28, Tomi Valkeinen wrote:
I don't quite understand this. We cannot have negative numbers in dts files? Or we can, but dt_binding_check doesn't handle them correctly? Or that int32 is not supported in yaml bindings?
AFAICT, you can have negative numbers in dts files (see [1] and [2]) and the DT schema certainly supports signed integers, but dt_binding_check seems to interpret all cells as unsigned 32bit integers because that's what they are, really. In kernel code this is not a problem because you can cast the value back to a signed int before you run your own sanity checks on them.
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/159682.html [2] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-April/159681.html
Cheers, Ricardo