Re: [PATCH v2 04/14] v4l: vsp1: Store source and sink pointers as vsp1_entity

Em Thu, 13 Jul 2017 14:00:31 +0100 Kieran Bingham kieran.bingham+renesas@ideasonboard.com escreveu:

Hi Laurent,

This looks like a good simplification/removal of obfuscation to me!

On 26/06/17 19:12, Laurent Pinchart wrote:

...

The internal VSP entity source and sink pointers are stored as media_entity pointers, which are then cast to a vsp1_entity. As all sources and sinks are vsp1_entity instances, we can store the vsp1_entity pointers directly.

Signed-off-by: Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com

Reviewed-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com

Acked-by: Mauro Carvalho Chehab mchehab@s-opensource.com

Thanks, Mauro