On Sun, 2020-02-02 at 00:11 +0100, Julian Sax wrote:
During normal usage, especially if jobs are started and stopped in rapid succession, the kernel log is filled with messages like this:
[38732.522910] Restoring PASID 0x8003 queues [38732.666767] Evicting PASID 0x8003 queues [38732.714074] Restoring PASID 0x8003 queues [38732.815633] Evicting PASID 0x8003 queues [38732.834961] Restoring PASID 0x8003 queues [38732.840536] Evicting PASID 0x8003 queues [38732.869846] Restoring PASID 0x8003 queues [38732.893655] Evicting PASID 0x8003 queues [38732.927975] Restoring PASID 0x8003 queues
According to [1], these messages are expected, but they carry little value for the end user, so turn them into debug messages.
trivia:
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager.c
[]
@@ -604,7 +604,7 @@ static int evict_process_queues_nocpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
- pr_debug_ratelimited("Evicting PASID 0x%x queues\n", pdd->process->pasid);
It would be nicer to realign all the subsequent lines in a single statement to the now moved open parenthesis.
/* Mark all queues as evicted. Deactivate all active queues on @@ -650,7 +650,7 @@ static int evict_process_queues_cpsch(struct device_queue_manager *dqm, goto out;
pdd = qpd_to_pdd(qpd);
- pr_info_ratelimited("Evicting PASID 0x%x queues\n",
- pr_debug_ratelimited("Evicting PASID 0x%x queues\n", pdd->process->pasid);
etc...