Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

On 09.09.2014 02:36, Alex Deucher wrote:

Updated version with comments integrated.

[...]

@@ -314,10 +314,12 @@ int radeon_bo_pin_restricted(struct radeon_bo *bo, u32 domain, u64 max_offset, unsigned lpfn = 0;

/* force to pin into visible video ram */

• if (bo->placements[i].flags & TTM_PL_FLAG_VRAM)
  

• 	lpfn = bo->rdev->mc.visible_vram_size >> PAGE_SHIFT;
  

• else
  

• if (bo->placements[i].flags & TTM_PL_FLAG_VRAM) {
  

• 	if (!(bo->flags & RADEON_GEM_NO_CPU_ACCESS))
  

• 		lpfn = bo->rdev->mc.visible_vram_size >> PAGE_SHIFT;
  

• } else {
  lpfn = bo->rdev->mc.gtt_size >> PAGE_SHIFT; /* ??? */
  

• }
  

The else block can be removed as well, but that can be done in another patch.

Either way, v2 is

Reviewed-by: Michel Dänzer michel.daenzer@amd.com