Hi, Yongqiang:
On Fri, 2020-01-03 at 11:12 +0800, Yongqiang Niu wrote:
Update device tree binding documention for rdma_fifo_size
Signed-off-by: Yongqiang Niu yongqiang.niu@mediatek.com
.../devicetree/bindings/display/mediatek/mediatek,disp.txt | 13 +++++++++++++ 1 file changed, 13 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt index 681502e..34bef44 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,disp.txt @@ -70,6 +70,10 @@ Required properties (DMA function blocks): argument, see Documentation/devicetree/bindings/iommu/mediatek,iommu.txt for details.
+Required properties (DMA function blocks): +- mediatek,rdma_fifo_size: rdma fifo size may be different even in same SOC, add this
- property to the corresponding rdma
I think "mediatek,rdma_fifo_size" is not a 'required' property. In mt8173.dtsi [1], there is no mediatek,rdma_fifo_size in rdma0, rdma1, and rdma2. So I think you should move this to 'optional' property.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch...
Regards, CK
Examples:
mmsys: clock-controller@14000000 { @@ -211,3 +215,12 @@ od@14023000 { power-domains = <&scpsys MT8173_POWER_DOMAIN_MM>; clocks = <&mmsys CLK_MM_DISP_OD>; };
+rdma1: rdma@1400c000 {
- compatible = "mediatek,mt8183-disp-rdma";
- reg = <0 0x1400c000 0 0x1000>;
- interrupts = <GIC_SPI 229 IRQ_TYPE_LEVEL_LOW>;
- power-domains = <&scpsys MT8183_POWER_DOMAIN_DISP>;
- clocks = <&mmsys CLK_MM_DISP_RDMA1>;
- mediatek,rdma_fifo_size = <2048>;
+}; \ No newline at end of file