Re: [PATCH 2/2] drm: Verify debug message arguments

On Mon, Apr 18, 2011 at 04:09:11PM -0700, Joe Perches wrote:

On Mon, 2011-04-18 at 16:01 -0700, Ian Romanick wrote:

...

...

@@ -214,9 +214,9 @@ parse_lfp_panel_data(struct drm_i915_private *dev_priv, i915_lvds_downclock) { dev_priv->lvds_downclock_avail = 1; dev_priv->lvds_downclock = temp_downclock;

• DRM_DEBUG_KMS("LVDS downclock is found in VBT. ",
  

• 		"Normal Clock %dKHz, downclock %dKHz\n",
  

• 		temp_downclock, panel_fixed_mode->clock);
  

• DRM_DEBUG_KMS("LVDS downclock is found in VBT. "
  

• 	      "Normal Clock %dKHz, downclock %dKHz\n",
  

• 	      temp_downclock, panel_fixed_mode->clock);
  

  } return;

}

Does this hunk only change white space, or am I missing something?

No, you're right. It's just whitespace. I prefer arguments aligned to open paren.

It's not just whitespace. Look at the end of first line.

Marcin