Re: [PATCH v3] drm/kmb: Add support for KeemBay Display

Hi Anitha.

A few extra details.

diff --git a/drivers/gpu/drm/kmb/kmb_crtc.c b/drivers/gpu/drm/kmb/kmb_crtc.c new file mode 100644 index 0000000..570d46e --- /dev/null +++ b/drivers/gpu/drm/kmb/kmb_crtc.c @@ -0,0 +1,219 @@ +// SPDX-License-Identifier: GPL-2.0-only +/*

• • Copyright © 2018-2020 Intel Corporation
• */

+#include <linux/clk.h> +#include <linux/of_graph.h>

Not used, can be dropped. Gos for all includes except the one in kmb_drv.c

+#include <linux/platform_data/simplefb.h>

Not used, can be dropped. Goes for all include of this file.

• /* disable vertical interrupt */
• kmb_clr_bitmask_lcd(dev_p, LCD_INT_ENABLE,

• 	LCD_INT_VERT_COMP);
  

+}

+static const struct drm_crtc_funcs kmb_crtc_funcs = {

• .destroy = kmb_crtc_cleanup,
• .set_config = drm_atomic_helper_set_config,

From the description of set_config:

* Drivers implementing atomic modeset should use * drm_atomic_helper_set_config() to implement this hook.

Sam