On 16 September 2014 04:51, Ezequiel Garcia ezequiel@vanguardiasur.com.ar wrote:
On 15 Sep 05:59 PM, Dave Airlie wrote:
On 15 September 2014 17:50, Ezequiel Garcia ezequiel@vanguardiasur.com.ar wrote:
Dave,
On 03 Sep 08:08 AM, Johannes Pointner wrote:
2014-09-02 14:51 GMT+02:00 Ezequiel Garcia ezequiel@vanguardiasur.com.ar:
Dave,
I'm resending this, hoping it can be pushed for v3.18. The patchset was ready for v3.17, but it got no maintainer feedback or review. Maybe it fell through some crack?
Just for reference, here goes the details about this series and why it's needed:
This patchset adds the required changes to support an optional backlight and GPIO for the tilcdc panel driver.
There was some code to support a backlight, but it was broken and undocumented. I've followed the nice implementation in panel-simple and added a similar one here.
The enable GPIO is required to turn on and off devices with such capability. Also here, I've followed panel-simple which looks correct.
In addition to this there are very minor cosmetic cleanups and a larger fix for the error path in tilcdc's DRM driver .load error path.
I tested the series with 3.16.1 (with additonal patches from Guido and Sachin) and with 3.17-rc3 with a custom AM335x board and it worked for me without an issue. I tried it with and without the backlight addition in the dts file.
For the series: Tested-by: Johannes Pointner johannes.pointner@br-automation.com
Any feedback for this series?
If at all possible, it'd be great to not miss the merge this time.
Could you stick it in a git tree somewhere? and send a pull request for it?
Hm.. I really don't have a git tree ready :/
Do you think you can pick the patches this time? I'll setup a tree as soon as possible.
Okay pushed to drm-next.
Dave.