31 May
2020
31 May
'20
5:18 p.m.
On Sun, 31 May 2020 at 14:12, Sidong Yang realwakka@gmail.com wrote:
Optimize looping pixels in compute_crc() and blend(). Calculate src_offset in start of looping horizontally and increase it. It's better than calculating in every pixels.
When you say "optimize" have you observed any actual benefits of the patch - be that smaller binary, faster execution time, etc? If there are - mentioned them in the commit message. Otherwise, it doesn't optimise anything.
A while back, I've suggested something similar [1] mostly for cosmetic purposes - doubt there's much benefits beyond that.
HTH -Emil [1] https://patchwork.freedesktop.org/patch/365177/#comment_674314