On Thu, Jan 14, 2021 at 11:00 AM Geert Uytterhoeven geert@linux-m68k.org wrote:
On Wed, Jan 13, 2021 at 6:02 PM Kieran Bingham kieran.bingham+renesas@ideasonboard.com wrote:
The encoder allocation was converted to a DRM managed resource at the same time as the addition of a new helper drmm_encoder_alloc() which simplifies the same process.
Convert the custom drm managed resource allocation of the encoder with the helper to simplify the implementation, and prevent hitting a WARN_ON() due to the handling the drm_encoder_init() call directly without registering a .destroy() function op.
Fixes: f5f16725edbc ("drm: rcar-du: Use DRM-managed allocation for encoders") Reported-by: Geert Uytterhoeven geert+renesas@glider.be Signed-off-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
Tested-by: Geert Uytterhoeven geert+renesas@glider.be As in "the WARNING from drm_encoder_init() is gone".
JFYI, the WARNING is now in v5.12-rc1, the fix isn't.
Gr{oetje,eeting}s,
Geert