Re: [PATCH v2 5/5] media: platform: Add Chrome OS EC CEC driver

On 05/15/2018 04:42 PM, Neil Armstrong wrote:

The Chrome OS Embedded Controller can expose a CEC bus, this patch add the driver for such feature of the Embedded Controller.

This driver is part of the cros-ec MFD and will be add as a sub-device when the feature bit is exposed by the EC.

The controller will only handle a single logical address and handles all the messages retries and will only expose Success or Error.

The controller will be tied to the HDMI CEC notifier by using the platform DMI Data and the i915 device name and connector name.

Signed-off-by: Neil Armstrong narmstrong@baylibre.com

<snip>

+static SIMPLE_DEV_PM_OPS(cros_ec_cec_pm_ops,

• cros_ec_cec_suspend, cros_ec_cec_resume);

+/*

• • The Firmware only handles single CEC interface tied to a single HDMI

single CEC -> a single CEC

• • connector we specify along the DRM device name handling the HDMI output

along -> along with

• */

+struct cec_dmi_match {

• char *sys_vendor;
• char *product_name;
• char *devname;
• char *conn;

+};

Looks good!

Regards,

Hans