On Tue, Nov 05, 2019 at 11:04:44AM +0100, Linus Walleij wrote:
On Fri, Oct 18, 2019 at 5:43 PM Arnd Bergmann arnd@arndb.de wrote:
The driver should not require a machine specific header. Change it to pass the gpio line through a lookup table, and move the timing generator definitions into the drivers itself.
Cc: Lee Jones lee.jones@linaro.org Cc: Daniel Thompson daniel.thompson@linaro.org Cc: Jingoo Han jingoohan1@gmail.com Cc: Bartlomiej Zolnierkiewicz b.zolnierkie@samsung.com Cc: dri-devel@lists.freedesktop.org Cc: linux-fbdev@vger.kernel.org Signed-off-by: Arnd Bergmann arnd@arndb.de
I'm not overly confident that I got the correct device names for the lookup table, it would be good if someone could double-check.
You're anyway doing more than required for the people who may or may not be using this platform. Brokenness can surely be fixed later, it's not like we are taking down the entire Amazon cloud or something.
Reviewed-by: Linus Walleij linus.walleij@linaro.org
Same here. I read, I did't see anything wrong but I can't test.
Reviewed-by: Daniel Thompson daniel.thompson@linaro.org
Daniel.