Re: [linux-sunxi] Re: [PATCH v5 02/11] clk: sunxi-ng: add support for DE2 CCU

On Mon, Apr 24, 2017 at 06:26:51PM +0800, icenowy@aosc.io wrote:

在 2017-04-24 16:51，Maxime Ripard 写道：

...

Hi,

On Sun, Apr 23, 2017 at 06:37:45PM +0800, Icenowy Zheng wrote:

...

+static const struct of_device_id sunxi_de2_clk_ids[] = {

• {

• .compatible = "allwinner,sun8i-a83t-de2-clk",
  

• .data = &sun8i_a83t_de2_clk_desc,
  

• },
• {

• .compatible = "allwinner,sun50i-h5-de2-clk",
  

• .data = &sun50i_a64_de2_clk_desc,
  

• },
• /*

• * The Allwinner A64 SoC needs some bit to be poke in syscon to make
  

• * DE2 really working.
  

• * So there's currently no A64 compatible here.
  

• * H5 shares the same reset line with A64, so here H5 is using the
  

• * clock description of A64.
  

• */
  

• { }

+};

So that A64 driver would require more than just what you defined in the binding in order to operate?

Yes. When trying to do A64 driver, I will send out first a patch to add the needed binding bit.

Then remove the A64 compatible from the binding document.

Thanks! Maxime