On 18-03-21, 10:22, Liu Ying wrote:
Can we have these in kernel-doc style please, similar to style in linux/phy/phy.h
I take this way of in-line member documentation comment for the below 3 reasons:
- Members of struct phy_configure_opts_mipi_dphy and
struct phy_configure_opts_dp use the same way of comment. The structures are defined in linux/phy/phy-mipi-dphy.h and linux/phy/phy-dp.h respectively. Aligning to them makes a bit sense, IMHO.
- In-line member documentation comments[1] are mentioned in kernel-doc
guide. It says 'The structure members may also be documented in-line within the definition.'.
- Even the 'configure' and 'validate' members of struct phy_ops use
the same way of comment. struct phy_ops is defined in linux/phy/phy.h.
[1] https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html#in-line-mem...
It 'may be' but I would like all headers of a subsystem to display one style. As I said linux/phy/phy.h use a style which we should use everywhere.
Thanks