Re: [PATCH libdrm v2 4/5] intel: make gen9 use generic gen macro

Quoting Lucas De Marchi (2018-08-29 01:35:31)

The 2 PCI IDs that are used for the command line overrid mechanism were left defined. The rest can be gone and then we just use the kernel defines.

Signed-off-by: Lucas De Marchi lucas.demarchi@intel.com

intel/intel_chipset.c | 5 ++ intel/intel_chipset.h | 187 +----------------------------------------- 2 files changed, 6 insertions(+), 186 deletions(-)

diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index 0c2ba884..c984d8ac 100644 --- a/intel/intel_chipset.c +++ b/intel/intel_chipset.c @@ -36,6 +36,11 @@ static const struct pci_device { } pciids[] = { INTEL_ICL_11_IDS(11), INTEL_CNL_IDS(10),

•   INTEL_CFL_IDS(9),
  

•   INTEL_GLK_IDS(9),
  

•   INTEL_KBL_IDS(9),
  

•   INTEL_BXT_IDS(9),
  

•   INTEL_SKL_IDS(9),
  

The gradual conversion lgtm. But why stop here? :) -Chris