On Wed, May 04, 2022 at 10:58:57PM +0200, Michael Walle wrote:
Am 2022-05-04 11:02, schrieb Lucas Stach:
While the labels may mislead the casual reader, the tail of the function etnaviv_ioctl_gem_submit is always executed, as a lot of the structures set up in this function need to be cleaned up regardless of whether the submit succeeded or failed.
An exception is the newly added drm_sched_job_cleanup, which must only be called when the submit failed before handing the job to the scheduler.
Fixes: b827c84f5e84 ("drm/etnaviv: Use scheduler dependency handling") Reported-by: Michael Walle michael@walle.cc Signed-off-by: Lucas Stach l.stach@pengutronix.de
FWIW (because it's already picked up)
Tested-by: Michael Walle michael@walle.cc
Thanks for confirming anyway, and apologies for breaking stuff - the bug has been pretty screaming when I looked at the changes in detail and I think I created it in one of the rebases and changes for drm_sched_job error handling, I should have been a bit more careful.
Cheers, Daniel