Re: [PATCH v2 1/2] drm/msm/gpu: Add ctx to get_param()

On Tue, Feb 1, 2022 at 8:16 AM Rob Clark robdclark@gmail.com wrote:

From: Rob Clark robdclark@chromium.org

Prep work for next patch.

Signed-off-by: Rob Clark robdclark@chromium.org

diff --git a/drivers/gpu/drm/msm/msm_rd.c b/drivers/gpu/drm/msm/msm_rd.c index 7e4d6460719e..dd3605b46264 100644 --- a/drivers/gpu/drm/msm/msm_rd.c +++ b/drivers/gpu/drm/msm/msm_rd.c @@ -197,13 +197,15 @@ static int rd_open(struct inode *inode, struct file *file)

    /* the parsing tools need to know gpu-id to know which
     * register database to load.

•    *
  

•    * Note: These particular param does not require a context
     */
  

Minor typo fix, "param does not" -> "params do not"

Other than that, series `Reviewed-by: Emma Anholt emma@anholt.net`

and I love that we're catching non-address-space associated faults now, too!