Re: [Intel-gfx] [PATCH 3/5] drm/i915: add SNB and IVB video sprite support

On Tue, Nov 08, 2011 at 10:57:03PM +0100, Daniel Vetter wrote:

...

• /*

• * Clamp the width & height into the visible area.  Note we don't
  

• * try to scale the source if part of the visible region is offscreen.
  

• * The caller must handle that by adjusting source offset and size.
  

• */
  

Allowing the crtc dest rect to extend beyond that of the crtc and then refusing to properly adjust tiling is a bit inconsistent. I call design-by-committee on this one ;-)

Oops, that comment went fubar while transferring from brainwaves to bits. Instead of "adjust tiling" it should be "adjust the source rectangle to the restricted crtc dest". -Daniel