On Tue, Jan 29, 2013 at 10:57 AM, Takashi Iwai tiwai@suse.de wrote:
At Tue, 29 Jan 2013 10:53:50 +0100, Daniel Vetter wrote:
On Tue, Jan 29, 2013 at 09:29:17AM +0100, Takashi Iwai wrote:
Add a new option, bpp, to specify the default bpp value.
Signed-off-by: Takashi Iwai tiwai@suse.de
This patch is applied on the top of previous two patches. I couldn't find an easy way to specify the default bpp, so I cooked the driver quickly. If there is any other convenient way to achieve this, let me know...
Well, you can specify the desired bpp with a full mode on the kernel cmdline - the '-bpp' extension. Reading through the parser I think it should work even with just the '-bpp' and not a full mode, but I haven't tested. Look for cmdline_mode->bpp_specified in drm_fb_helper.c and the relevant parsing code in drm_mode_parse_command_line_for_connector in drm_modes.c
If that doesn't work for you, I think it's better to extend/fix it than add driver module options.
Well, the fb can be set by that option, but the default modeset doesn't seem to honor it. So if you start X modeset driver, it still takes what the driver sets as default. That was the problem I hit.
Oh, I've missed the preferred_bpp hint for the generic modesetting driver. Can we fill that in by using the bpp parsed in the fb helper somehow? -Daniel