On Sat, Oct 29, 2011 at 2:25 AM, Daniel Vetter daniel@ffwll.ch wrote:
On Sat, Oct 29, 2011 at 12:47:18AM +0200, Tormod Volden wrote:
On Thu, Oct 27, 2011 at 1:07 PM, Daniel Vetter daniel.vetter@ffwll.ch wrote: ...
@@ -139,13 +99,35 @@ static int sis_drm_alloc(struct drm_device *dev, struct drm_file *file,
...
+#if defined(CONFIG_FB_SIS) || defined(CONFIG_FB_SIS_MODULE)
- item->req.size = mem->size;
- sis_malloc(&item->req);
- if (item->req.size == 0)
- retval = -ENOMEN;
ENOMEN is omen, I guess this was not compile tested with either CONFIG?
Oh gosh, this is embarassing ;-) I've indeed fumbled this and forgotten to check that config option. Smashed your patch on top of mine. btw, do you have some actual hw to test this on, or have you just checked out of curiosity?
I do not have sis hardware, but I am testing this on savage and my config happened to have this option set.
By the way, is there anything in special I can try to (stress-)test this? I have tested Quake III demos and multiple parallel GL screensaver hacks. On the other hand, is there a possibility this might fix some random DMA crashes or lock-ups (I mean the savage locking fix here)?
Thanks, Tormod
Thanks, Daniel
Daniel Vetter Mail: daniel@ffwll.ch Mobile: +41 (0)79 365 57 48