On Wed, Nov 17, 2021 at 08:43:19PM +0200, Ville Syrjälä wrote:
On Tue, Nov 16, 2021 at 09:48:18AM -0800, Matt Roper wrote:
From: Matt Atwood matthew.s.atwood@intel.com
Extend existing workaround 1409120013 to DG2.
I don't see this listed for DG2.
Cc: José Roberto de Souza jose.souza@intel.com Signed-off-by: Matt Atwood matthew.s.atwood@intel.com Signed-off-by: Matt Roper matthew.d.roper@intel.com
drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 89dc7f69baf3..e721c421cc58 100644 --- a/drivers/gpu/drm/i915/intel_pm.c +++ b/drivers/gpu/drm/i915/intel_pm.c @@ -7444,9 +7444,9 @@ static void icl_init_clock_gating(struct drm_i915_private *dev_priv)
static void gen12lp_init_clock_gating(struct drm_i915_private *dev_priv) {
- /* Wa_1409120013:tgl,rkl,adl-s,dg1 */
- /* Wa_1409120013:tgl,rkl,adl-s,dg1,dg2 */ if (IS_TIGERLAKE(dev_priv) || IS_ROCKETLAKE(dev_priv) ||
IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv))
IS_ALDERLAKE_S(dev_priv) || IS_DG1(dev_priv) || IS_DG2(dev_priv))
AFAIK we're not even calling this function on dg2, so this is just dead code. And in fact without dg2 this seems to be the same as DISPLAY_VER==12 so we shuld stop calling it on adl-p as well. We could then rip out most of the platform checks in here.
intel_uncore_write(&dev_priv->uncore, ILK_DPFC_CHICKEN, DPFC_CHICKEN_COMP_DUMMY_PIXEL);-- 2.33.0
-- Ville Syrjälä Intel