Re: [PATCH v4 1/8] drm/panel: Add an API drm_panel_get_orientation() to return panel orientation

Quoting Hsin-Yi Wang (2022-06-06 08:24:24)

diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index f634371c717a..e12056cfeca8 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -223,6 +223,15 @@ int drm_panel_get_modes(struct drm_panel *panel, } EXPORT_SYMBOL(drm_panel_get_modes);

+enum drm_panel_orientation drm_panel_get_orientation(struct drm_panel *panel)

Should 'panel' be marked const to indicate that it can't be modified?

+{

•   if (panel && panel->funcs && panel->funcs->get_orientation)
  

•           return panel->funcs->get_orientation(panel);