Re: [PATCH 1/2] fbdev: Fix sys_imageblit() for arbitrary image widths

Hello Thomas,

On 3/13/22 20:29, Thomas Zimmermann wrote:

Commit 6f29e04938bf ("fbdev: Improve performance of sys_imageblit()") broke sys_imageblit() for image width that are not aligned to 8-bit boundaries. Fix this by handling the trailing pixels on each line separately. The performance improvements in the original commit do not regress by this change.

Signed-off-by: Thomas Zimmermann tzimmermann@suse.de Fixes: 6f29e04938bf ("fbdev: Improve performance of sys_imageblit()") Cc: Thomas Zimmermann tzimmermann@suse.de Cc: Javier Martinez Canillas javierm@redhat.com Cc: Sam Ravnborg sam@ravnborg.org

---

Looks good to me. Also Marek and Geert mentioned that fixes the issue they were seeing.

Reviewed-by: Javier Martinez Canillas javierm@redhat.com