Re: [Intel-gfx] [PATCH 2/4] drm: setclientcap doesn't need the drm BKL

On Sat, Dec 10, 2016 at 10:52:53PM +0100, Daniel Vetter wrote:

It only updates per-file feature flags. And all the ioctl which change behaviour depending upon these flags (they're all kms features) do _not_ hold the BKL. Therefor this is pure cargo-cult and can be removed.

Note that there's a risk that the ioctl will behave inconsistently,

+ if userspace is racing with itself,

but that's ok. The only thing it's not allowed to do is oops the kernel, and from an audit all places are safe.

Signed-off-by: Daniel Vetter daniel.vetter@intel.com

Reviewed-by: Chris Wilson chris@chris-wilson.co.uk -Chris