Re: [PATCH] drm/i915: Fix up usage of SHRINK_STOP

On Wed, Sep 25, 2013 at 02:00:02PM +0200, Daniel Vetter wrote:

In

commit 81e49f811404f428a9d9a63295a0c267e802fa12 Author: Glauber Costa glommer@openvz.org Date: Wed Aug 28 10:18:13 2013 +1000

i915: bail out earlier when shrinker cannot acquire mutex

SHRINK_STOP was added to tell the core shrinker code to bail out and go to the next shrinker since the i915 shrinker couldn't acquire required locks. But the SHRINK_STOP return code was added to the ->count_objects callback and not the ->scan_objects callback as it should have been, resulting in tons of dmesg noise like

shrink_slab: i915_gem_inactive_scan+0x0/0x9c negative objects to delete nr=-xxxxxxxxx

Fix discusssed with Dave Chinner.

Acked-by: Dave Chinner dchinner@redhat.com

Cheers,

Dave.