On 2019/07/15, Sam Ravnborg wrote:
Hi Emil.
The list of cc: was too large to add all recipients to the cover letter. Please find cover letter here: https://lists.freedesktop.org/archives/dri-devel/2019-June/thread.html Search for "drm: drop use of drmp.h in drm-misc"
Speaking of long CC list, most patches are ok yet this has gone a bit crazy. How did you manage to pull such a long list? The get_maintainer.pl script shows a total of 17 for all of hibmc and kirin.
Sometimes scripts/get_maintainer.pl outputs a lot of people. Sometimes only a few. I have not looked into details why, and for this patch series I used "dim add-missing-cc" to most patches.
This patch seems like a good candidate to fixup dim. Can we volunteer you for the task ;-)
Either way, since you've built-tested these (and conflicts are a matter of #include) for the lot: Acked-by: Emil Velikov emil.velikov@collabora.com
Just to be sure. Was this an Ack for the full series or only this patch? I started processing the patches, and the ones where I have got an explicit ack or r-b is queued already (without your ack).
For the lot -> For the series.
There are still ~20 patches without feedback in this series, and I would love to have them processed and pushed out.
Personally I'm inclined that we can push the series even with an ack-by. Any potential issues raised by a #include reshuffle would be caught by a build - which you've already done.
Tl;Dr: If it were me - ship it :-P
HTH Emil