Hi Christian,
On Mon, Oct 18, 2021 at 1:41 PM Christian König christian.koenig@amd.com wrote:
Am 18.10.21 um 13:38 schrieb Geert Uytterhoeven:
On Mon, Oct 18, 2021 at 1:37 PM Christian König christian.koenig@amd.com wrote:
Am 13.10.21 um 16:42 schrieb Arnd Bergmann:
From: Arnd Bergmann arnd@arndb.de
When CONFIG_COMMON_CLOCK is disabled, the 8996 specific phy code is left out, which results in a link failure:
ld: drivers/gpu/drm/msm/hdmi/hdmi_phy.o:(.rodata+0x3f0): undefined reference to `msm_hdmi_phy_8996_cfg'
This was only exposed after it became possible to build test the driver without the clock interfaces.
Make COMMON_CLK a hard dependency for compile testing, and simplify it a little based on that.
Fixes: b3ed524f84f5 ("drm/msm: allow compile_test on !ARM") Reported-by: Randy Dunlap rdunlap@infradead.org Suggested-by: Geert Uytterhoeven geert@linux-m68k.org Signed-off-by: Arnd Bergmann arnd@arndb.de
drivers/gpu/drm/msm/Kconfig | 2 +- drivers/gpu/drm/msm/Makefile | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/msm/Kconfig b/drivers/gpu/drm/msm/Kconfig index f5107b6ded7b..cb204912e0f4 100644 --- a/drivers/gpu/drm/msm/Kconfig +++ b/drivers/gpu/drm/msm/Kconfig @@ -4,8 +4,8 @@ config DRM_MSM tristate "MSM DRM" depends on DRM depends on ARCH_QCOM || SOC_IMX5 || COMPILE_TEST
depends on COMMON_CLK depends on IOMMU_SUPPORTWe also need a "depends on MMU" here because some automated test is now trying to compile the driver on parisc as well.
I have absolutely no idea how a platform can have IOMMU but no MMU support but it indeed seems to be the case here.
Huh?
Parisc has config MMU def_bool y?
Then why vmap isn't available?
See the mail thread: [linux-next:master 3576/7806] drivers/gpu/drm/msm/msm_gem.c:624:20: error: implicit declaration of function 'vmap'
You mean https://lore.kernel.org/all/202110141259.i36iJnsA-lkp@intel.com/?
Hexagon != parisc. . And Hexagon also has config MMU def_bool y
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds