On Wed, Jan 13, 2021 at 01:53:38PM +0100, Stefan Wahren wrote:
Hi Maxime,
Am 13.01.21 um 10:15 schrieb Maxime Ripard:
Hi,
On Sat, Jan 09, 2021 at 11:50:32AM +0100, Stefan Wahren wrote:
This converts the v3d bindings to yaml format.
Signed-off-by: Stefan Wahren stefan.wahren@i2se.com
...
diff --git a/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml new file mode 100644 index 0000000..3b543d4 --- /dev/null +++ b/Documentation/devicetree/bindings/gpu/brcm,bcm-v3d.yaml @@ -0,0 +1,72 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/gpu/brcm,bcm-v3d.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Broadcom V3D GPU Bindings
+maintainers:
- Eric Anholt eric@anholt.net
- Nicolas Saenz Julienne nsaenzjulienne@suse.de
+properties:
- $nodename:
- pattern: '^gpu@[a-f0-9]+$'
- compatible:
- enum:
- brcm,7268-v3d- brcm,7278-v3d- reg:
- items:
- description: hub register (required)- description: core0 register (required)- description: GCA cache controller register (if GCA controller present)- description: bridge register (if no external reset controller)- minItems: 2
maxItems will be set to 2 in this case, while it would be 4 I guess?
This confuses me. Based on this patch [1] by Rob, i would assume that maxItems is derived from item list length.
[1] - https://lists.freedesktop.org/archives/dri-devel/2020-December/292309.html
Yeah, you're right
My understanding was that maxItems was set to whatever minItems was if maxItems was missing, but dt-validate also checks for whether it's a list and will fill it like you said:
https://github.com/devicetree-org/dt-schema/blob/master/dtschema/lib.py#L258
Maxime