Hi
Am 12.05.22 um 12:38 schrieb Jocelyn Falempe: ...
One suggestion to avoid too much repetition:
static int mgag200_get_bandwidth_kbps(mdev) {
if (IS_G200_SE(mdev)) { u32 unique_rev_id = mdev->model.g200se.unique_rev_id;
if (unique_rev_id == 0x01) { return 24400; } else if (unique_rev_id == 0x02) { return 30100; ...
} else if (mdev->type == G200_ER) { return 55000; } /* No bandwidth defined */ return 0; }
then in mgag200_mode_config_mode_valid()
int g200_bandwidth = mgag200_get_bandwidth_kbps(mdev);
if (g200_bandwidth && mgag200_calculate_mode_bandwidth(mode, max_bpp * 8) > g200_bandwidth * 1024) return MODE_BAD;
FYI that code will soon be parameterized via model-specific constants.
Best regards Thomas
I've also tested this patchset, and have seen no regression.
you can add
Reviewed-by: Jocelyn Falempe jfalempe@redhat.com Tested-by: Jocelyn Falempe jfalempe@redhat.com
for the whole series.