Re: [PATCH V5 3/6] dt-bindings: display: mediatek: revise enum to const

Hello Rob,

Thanks for your review. I have sent v6 to fix this error.

https://lore.kernel.org/all/20220303065725.23384-3-rex-bc.chen@mediatek.com/

BRs, Rex

On Wed, 2022-03-02 at 12:29 -0600, Rob Herring wrote:

On Tue, Mar 01, 2022 at 04:01:02PM +0800, Rex-BC Chen wrote:

...

There won't be more than 1 fallback for these bindings, so we modify them to use const instead of enum.

Signed-off-by: Rex-BC Chen rex-bc.chen@mediatek.com

.../devicetree/bindings/display/mediatek/mediatek,aal.yaml | 2 +- .../devicetree/bindings/display/mediatek/mediatek,ccorr.yaml | 2 +- .../devicetree/bindings/display/mediatek/mediatek,color.yaml | 4 ++-- .../devicetree/bindings/display/mediatek/mediatek,dither.yaml | 2 +- .../devicetree/bindings/display/mediatek/mediatek,gamma.yaml | 2 +- .../devicetree/bindings/display/mediatek/mediatek,ovl.yaml | 4 ++-- .../devicetree/bindings/display/mediatek/mediatek,rdma.yaml | 4 ++-- 7 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y aml b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y aml index 191b56e16bee..bc1c70d089ba 100644

---

a/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y aml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,aal.y aml @@ -31,7 +31,7 @@ properties: - mediatek,mt8183-disp-aal - mediatek,mt8192-disp-aal - mediatek,mt8195-disp-aal

•      - enum:
  

•      - const:
           - mediatek,mt8173-disp-aal
  

Run 'make dt_binding_check'. This will fail.

...

reg: diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr .yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr .yaml index 6894b6999412..fc40e2981eaa 100644

---

a/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr .yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ccorr .yaml @@ -28,7 +28,7 @@ properties: - items: - enum: - mediatek,mt8195-disp-ccorr

•      - enum:
  

•      - const:
           - mediatek,mt8192-disp-ccorr
  
  

  reg:

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,color .yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,color .yaml index bc83155b3b4c..22ed5d368cbe 100644

---

a/Documentation/devicetree/bindings/display/mediatek/mediatek,color .yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,color .yaml @@ -32,14 +32,14 @@ properties: - enum: - mediatek,mt7623-disp-color - mediatek,mt2712-disp-color

•      - enum:
  

•      - const:
           - mediatek,mt2701-disp-color
   - items:
       - enum:
           - mediatek,mt8183-disp-color
           - mediatek,mt8192-disp-color
           - mediatek,mt8195-disp-color
  

•      - enum:
  

•      - const:
           - mediatek,mt8173-disp-color
  

  reg: maxItems: 1

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe r.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe r.yaml index 9d89297f5f1d..2a82792b2625 100644

---

a/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe r.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dithe r.yaml @@ -28,7 +28,7 @@ properties: - enum: - mediatek,mt8192-disp-dither - mediatek,mt8195-disp-dither

•      - enum:
  

•      - const:
           - mediatek,mt8183-disp-dither
  
  

  reg:

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma .yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma .yaml index 247baad147b3..45f88bdf07bb 100644

---

a/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma .yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,gamma .yaml @@ -29,7 +29,7 @@ properties: - enum: - mediatek,mt8192-disp-gamma - mediatek,mt8195-disp-gamma

•      - enum:
  

•      - const:
           - mediatek,mt8183-disp-gamma
  
  

  reg:

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y aml b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y aml index e71f79bc2dee..88ba3f27b0e4 100644

---

a/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y aml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,ovl.y aml @@ -33,12 +33,12 @@ properties: - enum: - mediatek,mt7623-disp-ovl - mediatek,mt2712-disp-ovl

•      - enum:
  

•      - const:
           - mediatek,mt2701-disp-ovl
   - items:
       - enum:
           - mediatek,mt8195-disp-ovl
  

•      - enum:
  

•      - const:
           - mediatek,mt8183-disp-ovl
  
  

  reg:

diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma. yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma. yaml index 8ef821641672..56368c10d904 100644

---

a/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma. yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,rdma. yaml @@ -35,12 +35,12 @@ properties: - enum: - mediatek,mt7623-disp-rdma - mediatek,mt2712-disp-rdma

•      - enum:
  

•      - const:
           - mediatek,mt2701-disp-rdma
   - items:
       - enum:
           - mediatek,mt8192-disp-rdma
  

•      - enum:
  

•      - const:
           - mediatek,mt8183-disp-rdma
  
  

  reg:

-- 2.18.0

---

linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org

https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linu...

...