Re: [PATCH v6 2/2] drm/panel: Add Sitronix ST7701 panel driver

On Sat, Dec 15, 2018 at 2:16 AM Jagan Teki jagan@amarulasolutions.com wrote:

ST7701 designed for small and medium sizes of TFT LCD display, is capable of supporting up to 480RGBX864 in resolution. It provides several system interfaces like MIPI/RGB/SPI.

Currently added support for Techstar TS8550B which is ST7701 based 480x854, 2-lane MIPI DSI LCD panel.

Driver now registering mipi_dsi device, but indeed it can extendable for RGB if any requirement trigger in future.

Signed-off-by: Jagan Teki jagan@amarulasolutions.com

Changes for v6:

• use sleep delay value as per datasheet
• add panel_sleep_delay variable for panel specific delay
• use command sequnce display on and off instead panel functions
• add proper comments on the delays
• remove delays from command switch
• move mode type on struct display mode
• drop refresh rate value, let drm compute

Changes for v5:

• found the chip from vendor, so added new panel driver
• here is v4: https://patchwork.kernel.org/patch/10680335/

Any comments?