Re: [PATCH 1/3] drm/panel: ltk050h3146w: add mipi_dsi_device.mode_flags to of_match_data

Hi all,

Seems I'm not the only one who forgot about this patch series, so, kindly pinging :)

Thanks! Quentin

On 1/31/22 17:47, quentin.schulz@theobroma-systems.com wrote:

From: Quentin Schulz quentin.schulz@theobroma-systems.com

To prepare for a new display to be supported by this driver which has a slightly different set of DSI mode related flags, let's move the currently hardcoded mode flags to the .data field of of_device_id structure.

Cc: Quentin Schulz foss+kernel@0leil.net Signed-off-by: Quentin Schulz quentin.schulz@theobroma-systems.com

---

drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c index a5a414920430..67eb474e28c6 100644 --- a/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c +++ b/drivers/gpu/drm/panel/panel-leadtek-ltk050h3146w.c @@ -25,6 +25,7 @@ struct ltk050h3146w_cmd {

struct ltk050h3146w; struct ltk050h3146w_desc {

• const unsigned long mode_flags; const struct drm_display_mode *mode; int (*init)(struct ltk050h3146w *ctx); };

@@ -339,6 +340,8 @@ static const struct drm_display_mode ltk050h3146w_mode = { static const struct ltk050h3146w_desc ltk050h3146w_data = { .mode = &ltk050h3146w_mode, .init = ltk050h3146w_init_sequence,

• .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |

• MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET,
  

  };

  static int ltk050h3146w_a2_select_page(struct ltk050h3146w *ctx, int page)

@@ -433,6 +436,8 @@ static const struct drm_display_mode ltk050h3146w_a2_mode = { static const struct ltk050h3146w_desc ltk050h3146w_a2_data = { .mode = &ltk050h3146w_a2_mode, .init = ltk050h3146w_a2_init_sequence,

• .mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |

• MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET,
  

  };

  static int ltk050h3146w_unprepare(struct drm_panel *panel)

@@ -592,8 +597,7 @@ static int ltk050h3146w_probe(struct mipi_dsi_device *dsi)

dsi->lanes = 4; dsi->format = MIPI_DSI_FMT_RGB888;

• dsi->mode_flags = MIPI_DSI_MODE_VIDEO | MIPI_DSI_MODE_VIDEO_BURST |

• 	  MIPI_DSI_MODE_LPM | MIPI_DSI_MODE_NO_EOT_PACKET;
  

• dsi->mode_flags = ctx->panel_desc->mode_flags;

  drm_panel_init(&ctx->panel, &dsi->dev, &ltk050h3146w_funcs, DRM_MODE_CONNECTOR_DSI);