16 Jul
2018
16 Jul
'18
10:16 p.m.
On Mon, Jul 16 2018, Andy Shevchenko wrote:
On Fri, 2018-07-13 at 16:42 -0700, Randy Dunlap wrote:
On 07/13/2018 04:37 PM, NeilBrown wrote:
coding-style.rst says: Also, use braces when a loop contains more than a single simple statement:
Independently on a) would we use some macro for condition, or b) fix macros against this kind of nested conditions, there is another weirdness we would like to avoid, i.e.
for_each_foo() { ... } else { ... }
It is written according to coding style, but too much weird.
Agreed. Too weird.
So, summarize this discussion I think we would
- keep for_each_if() in DRM subsystem alone
- fix macros which are using positive condition 'if (cond)' by replacing
with 'if (!cond) {} else' form for sake of robustness.
Do you agree on that?
I agree.
Thanks, NeilBrown