On 4/4/2022 12:38 PM, Jason Gunthorpe wrote:
On Fri, Apr 01, 2022 at 04:08:35PM -0400, Felix Kuehling wrote:
In general I find the vm_normal_lru_page vs vm_normal_page API highly confusing. An explicit check for zone device pages in the dozen or so spots that care has a much better documentation value, especially if accompanied by comments where it isn't entirely obvious.
OK. We can do that. It would solve the function naming problem, and we'd have more visibility of device page handling in more places in the kernel, which has educational value.
Personally I find the 'is page XYZ' pretty confusing, like I don't know half of what the PageKsm annotations are for..
Testing against a specific property the code goes on to use right away seems more descriptive to me.
Hi Jason,
Are you referring to test for properties such as is_lru_page, is_numa_page, is_lockable_page, etc? Otherwise, could you provide an example?
Regards, Alex Sierra
Jason