On Tue, Jun 7, 2022 at 3:16 AM Stephen Boyd swboyd@chromium.org wrote:
Quoting Hsin-Yi Wang (2022-06-06 08:24:31)
diff --git a/drivers/gpu/drm/mediatek/mtk_dsi.c b/drivers/gpu/drm/mediatek/mtk_dsi.c index d9f10a33e6fa..c56282412bfa 100644 --- a/drivers/gpu/drm/mediatek/mtk_dsi.c +++ b/drivers/gpu/drm/mediatek/mtk_dsi.c @@ -822,6 +823,12 @@ static int mtk_dsi_encoder_init(struct drm_device *drm, struct mtk_dsi *dsi) ret = PTR_ERR(dsi->connector); goto err_cleanup_encoder; }
/* Read panel orientation */if (dsi->panel)drm_connector_set_panel_orientation(dsi->connector,drm_panel_get_orientation(dsi->panel));It could be simplified like so?
drm_connector_set_orientation_from_panel(dsi->connector, dsi->panel);Then the API could get the orientation if the panel pointer is valid. Does any code need to use/modify the orientation value besides drm_connector_set_panel_orientation()?
We can add another function to call drm_connector_set_orientation_from_panel(), which will be like
void drm_connector_set_orientation_from_panel(connector, panel) { if (panel) drm_connector_set_panel_orientation(connector,drm_panel_get_orientation(panel)); }
Though it's very should but I can add this if this can make the caller more convenient.
drm_connector_attach_encoder(dsi->connector, &dsi->encoder); return 0;