Re: [PATCH v7 1/2] dt-bindings: display: panel: Add bindings for Novatek nt36672a

Hi Sam,

On Thu, 15 Oct 2020 at 00:14, Sam Ravnborg sam@ravnborg.org wrote:

Hi Sumit. On Wed, Sep 02, 2020 at 12:14:06PM +0530, Sumit Semwal wrote:

...

Novatek nt36672a is a display driver IC that can drive DSI panel. It is also present in the Tianma video mode panel, which is a FHD+ panel with a resolution of 1080x2246 and 6.18 inches size. It is found in some of the Poco F1 phones.

This patch adds the display driver for the IC, with support added for this tianma fhd video mode panel.

Signed-off-by: Sumit Semwal sumit.semwal@linaro.org Reviewed-by: Rob Herring robh@kernel.org

Reviewed-by: Sam Ravnborg sam@ravnborg.org I assume you will apply the patch yourself.

Thanks, I will.

    Sam

Best, Sumit.

...

---

v2: remove ports node, making port@0 directly under panel@0 node. v3: updated to replace port@0 to just 'port'. v5: renamed to novatek,nt36672a, since the binding is for the IC and not the panel. v6: v5 review comments incorporated. - added enum for the compatible part, since it can be extended in future. - few cosmetic updates.

---

.../display/panel/novatek,nt36672a.yaml | 87 +++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml

diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml new file mode 100644 index 000000000000..d2170de6b723 --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml @@ -0,0 +1,87 @@ +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/novatek,nt36672a.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#

+title: Novatek NT36672A based DSI display Panels

+maintainers:

• • Sumit Semwal sumit.semwal@linaro.org

+description: |

• The nt36672a IC from Novatek is a generic DSI Panel IC used to drive dsi
• panels.
• Right now, support is added only for a Tianma FHD+ LCD display panel with a
• resolution of 1080x2246. It is a video mode DSI panel.

+allOf:

• • $ref: panel-common.yaml#

+properties:

• compatible:
• items:

•  - enum:
  

•     - tianma,fhd-video
  

•  - const: novatek,nt36672a
  

• description: This indicates the panel manufacturer of the panel that is

•  in turn using the NT36672A panel driver. This compatible string
  

•  determines how the NT36672A panel driver is configured for the indicated
  

•  panel. The novatek,nt36672a compatible shall always be provided as a fallback.
  

• reset-gpios:
• description: phandle of gpio for reset line - This should be 8mA, gpio

•  can be configured using mux, pinctrl, pinctrl-names (active high)
  

• vddio-supply:
• description: phandle of the regulator that provides the supply voltage

•  Power IC supply
  

• vddpos-supply:
• description: phandle of the positive boost supply regulator
• vddneg-supply:
• description: phandle of the negative boost supply regulator
• reg: true
• port: true

+required:

• • compatible
• • reg
• • vddi0-supply
• • vddpos-supply
• • vddneg-supply
• • reset-gpios
• • port

+unevaluatedProperties: false

+examples:

• • |+
• #include <dt-bindings/gpio/gpio.h>
• dsi0 {

•    #address-cells = <1>;
  

•    #size-cells = <0>;
  

•    panel@0 {
  

•        compatible = "tianma,fhd-video", "novatek,nt36672a";
  

•        reg = <0>;
  

•        vddi0-supply = <&vreg_l14a_1p88>;
  

•        vddpos-supply = <&lab>;
  

•        vddneg-supply = <&ibb>;
  

•        reset-gpios = <&tlmm 6 GPIO_ACTIVE_HIGH>;
  

•        #address-cells = <1>;
  

•        #size-cells = <0>;
  

•        port {
  

•            tianma_nt36672a_in_0: endpoint {
  

•                remote-endpoint = <&dsi0_out>;
  

•            };
  

•        };
  

•    };
  

• };

+...

2.28.0

---

dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel