On Thursday, December 3, 2020 1:54 PM, Ville Syrjälä ville.syrjala@linux.intel.com wrote:
The drm_fourcc.h maybe makes some sense (I think in some places mesa uses these internally, and many drivers use the modifiers directly in the main driver). But the amdgpu header should be all ioctl stuff, which should be all entirely in the winsys only. Also kinda disappointing that drm_fourcc.h includes drm.h and isn't standalone, but I guess that sailed (at least for linux).
Isn't the only thing it needs the __u32? I would think we could just replace those with unsigned int (DRM_FORMAT_BIG_ENDIAN already assumes int is 32bit it seems) and drop the drm.h.
Or are we're worried something already depends on getting drm.h via just including drm_fourcc.h?
Yes, some user-space might only include drm_fourcc.h and use stuff coming from drm.h.