Re: [PATCH v2 10/26] ARM: sun5i: a13: Add display and TCON clocks

Hi,

On Sun, Jan 17, 2016 at 01:06:07AM +0800, Chen-Yu Tsai wrote:

...

•                   compatible = "allwinner,sun4i-a10-tcon-ch0-clk";
  

•                   reg = <0x01c20118 0x4>;
  

•                   clocks = <&pll3>, <&pll7>, <&pll3x2>, <&pll7x2>;
  

•                   clock-output-names = "tcon-ch0-sclk";
  

•           };
  

•           tcon_ch1_clk: clk@01c2012c {
  

•                   #clock-cells = <0>;
  

•                   compatible = "allwinner,sun4i-a10-tcon-ch1-clk";
  

•                   reg = <0x01c2012c 0x4>;
  

•                   clocks = <&pll3>, <&pll7>, <&pll3x2>, <&pll7x2>;
  

•                   clock-output-names = "tcon-ch1-sclk";
  

•           };
  

I suggest moving these to sun5i.dtsi, as they are shared amongst them.

Eventually, yes, but I don't have an a10s board handy, and I couldn't test the clocks that needs to be taken by simplefb.

Once properly tested, they can definitely be moved to sun5i.dtsi.

Thanks! Maxime