On 11/12/2012 11:47 PM, Thierry Reding wrote:
On Mon, Nov 12, 2012 at 05:17:18PM -0700, Stephen Warren wrote:
On 11/12/2012 02:55 PM, Thierry Reding wrote:
This second version of this patch series addresses all the comments received so far. Most notably it takes advantage of the debugfs helpers provided by the DRM core. Oddly enough this actually increases the line count, but that's because the helpers don't fit with the subdevices approach as implemented by this driver. However some quick discussions with Rob Clark showed that Tegra DRM is not special in this respect but other drivers may need the same functionality. Eventually the debugfs code could be reworked on top of helpers that are better suited at the design of embedded, multi-device DRM drivers.
Other than that there is some removal of code that was actually supposed to go into a later patch because it has dependencies that haven't been merged yet and some moving around of #defines and the device tree bindings documentation. Finally the driver now uses the DRM core's drm_compat_ioctl() instead of a custom and unimplemented (!) version.
The series,
Tested-by: Stephen Warren swarren@nvidia.com
(on the Harmony board's HDMI output; I'll test other boards/outputs later).
You also gave an Acked-by for the DT binding documentation in the first version of this patchset, does it apply to the rest of the patch as well? That is, can I add it to patch 1?
I didn't actually read the rest of the patch since there are many people much more familiar with the host1x/... code that will provide useful feedback.
However, yes, I think it's fine to include my ack in the patch - it's common to ack only parts of patches I believe.