Re: [PATCH v1 1/5] drm: mxsfb: Print failed bus format in hex

On Tue, 28 Sept 2021 at 14:16, Guido Günther agx@sigxcpu.org wrote:

media-bus-formats.h has them in hexadecimal as well so matching with that file saves one conversion when debugging.

Signed-off-by: Guido Günther agx@sigxcpu.org

drivers/gpu/drm/mxsfb/mxsfb_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/mxsfb/mxsfb_kms.c b/drivers/gpu/drm/mxsfb/mxsfb_kms.c index af6c620adf6e..d6abd2077114 100644 --- a/drivers/gpu/drm/mxsfb/mxsfb_kms.c +++ b/drivers/gpu/drm/mxsfb/mxsfb_kms.c @@ -89,7 +89,7 @@ static void mxsfb_set_formats(struct mxsfb_drm_private *mxsfb, ctrl |= CTRL_BUS_WIDTH_24; break; default:

•           dev_err(drm->dev, "Unknown media bus format %d\n", bus_format);
  

•           dev_err(drm->dev, "Unknown media bus format 0x%x\n", bus_format);
            break;
    }
  

Reviewed-by: Robert Foss robert.foss@linaro.org