Re: [PATCH v5 1/6] dt-bindings: add bindings for USB physical connector

Hi,

On Tue, Feb 27, 2018 at 08:11:29AM +0100, Andrzej Hajda wrote:

+2. USB-C connector attached to CC controller (s2mm005), HS lines routed +to companion PMIC (max77865), SS lines to USB3 PHY and SBU to DisplayPort. +DisplayPort video lines are routed to the connector via SS mux in USB3 PHY.

+ccic: s2mm005@33 {

• ...
• usb_con: connector {

• compatible = "usb-c-connector";
  

• label = "USB-C";
  

Is this child node really necessary? There will never be more then one connector per CC line.

We should prefer device_graph* functions over of_graph* and acpi_graph* functions in the drivers so we don't have to handle the same thing multiple times with separate APIs. Is it still possible if there is that connector child node?

• ports {
  

• 	#address-cells = <1>;
  

• 	#size-cells = <0>;
  

• 	port@0 {
  

• 		reg = <0>;
  

• 		usb_con_hs: endpoint {
  

• 			remote-endpoint = <&max77865_usbc_hs>;
  

• 		};
  

• 	};
  

• 	port@1 {
  

• 		reg = <1>;
  

• 		usb_con_ss: endpoint {
  

• 			remote-endpoint = <&usbdrd_phy_ss>;
  

• 		};
  

• 	};
  

• 	port@2 {
  

• 		reg = <2>;
  

• 		usb_con_sbu: endpoint {
  

• 			remote-endpoint = <&dp_aux>;
  

• 		};
  

• 	};
  

• };
  

• };

+};

Thanks,