Hi Kieran,
On Friday, 15 September 2017 20:49:15 EEST Kieran Bingham wrote:
On 15/09/17 18:02, Laurent Pinchart wrote:
On Friday, 15 September 2017 19:42:06 EEST Kieran Bingham wrote:
The pipeline needs to ensure that the hardware is idle for suspend and resume operations.
I'm not sure to really understand this sentence.
It makes sense to me ... :) - But I'm not the (only) target audience.
How about re-wording it in a similar way to your suggestion in [1/3]
""" To support system suspend operations we must ensure the hardware is stopped, and resumed explicitly from the suspend and resume handlers.
Implement suspend and resume functions using the DRM atomic helper functions. """
Sounds good to me. I'll update the commit message in my tree, and update the subject line to "drm: rcar-du: Implement system suspend/resume support".
Implement suspend and resume functions using the DRM atomic helper functions.
CC: dri-devel@lists.freedesktop.org
Signed-off-by: Kieran Bingham kieran.bingham+renesas@ideasonboard.com
The rest of the patch looks good to me. With the commit message clarified,
Reviewed-by: Laurent Pinchart laurent.pinchart@ideasonboard.com
drivers/gpu/drm/rcar-du/rcar_du_drv.c | 18 +++++++++++++++--- drivers/gpu/drm/rcar-du/rcar_du_drv.h | 1 + 2 files changed, 16 insertions(+), 3 deletions(-)
[snip]