Hey Laurent,
On 13 December 2016 at 19:34, Laurent Pinchart laurent.pinchart+renesas@ideasonboard.com wrote:
From: Laurent Pinchart laurent.pinchart@ideasonboard.com
The drm driver .load() operation is prone to race conditions as it initializes the driver after registering the device nodes. Its usage is deprecated, inline it in the probe function and call drm_dev_alloc() and drm_dev_register() explicitly.
For consistency inline the .unload() handler in the remove function as well.
Almost there: you need to add 'drm->platformdev = to_platform_device(dev)' next to the drm->dev_private assignment. I thought about cleaning this up, but my XU3's eMMC is dead, so testing on Exynos for me has a 5+ minute RTT through LAVA ... so this is:
Reviewed-by: Daniel Stone daniels@collabora.com
Cheers, Daniel