Re: [PATCH 16/22] drm/omap: Nuke close hooks

Hi Daniel,

On 11/01/16 23:41, Daniel Vetter wrote:

diff --git a/drivers/gpu/drm/omapdrm/omap_drv.c b/drivers/gpu/drm/omapdrm/omap_drv.c index dfafdb602ad2..603a65498b40 100644 --- a/drivers/gpu/drm/omapdrm/omap_drv.c +++ b/drivers/gpu/drm/omapdrm/omap_drv.c @@ -175,17 +175,6 @@ static int omap_atomic_commit(struct drm_device *dev, priv->commit.pending |= commit->crtcs; spin_unlock(&priv->commit.lock);

• /* Keep track of all CRTC events to unlink them in preclose(). */
• spin_lock_irqsave(&dev->event_lock, flags);
• for (i = 0; i < dev->mode_config.num_crtc; ++i) {

• struct drm_crtc_state *cstate = state->crtc_states[i];
  

• if (cstate && cstate->event)
  

• 	list_add_tail(&cstate->event->base.link,
  

• 		      &priv->commit.events);
  

• }
• spin_unlock_irqrestore(&dev->event_lock, flags);
• /* Swap the state, this is the point of no return. */ drm_atomic_helper_swap_state(dev, state);

'flags' local needs to be removed from omap_atomic_commit, otherwise:

drivers/gpu/drm/omapdrm/omap_drv.c:145:16: error: unused variable 'flags'

Tomi