On 10/04/2017 06:24 PM, Boris Brezillon wrote:
cma_alloc() unconditionally prints an INFO message when the CMA allocation fails. Make this message conditional on the non-presence of __GFP_NOWARN in gfp_mask.
Signed-off-by: Boris Brezillon boris.brezillon@free-electrons.com
Hello,
This patch aims at removing INFO messages that are displayed when the VC4 driver tries to allocate buffer objects. From the driver perspective an allocation failure is acceptable, and the driver can possibly do something to make following allocation succeed (like flushing the VC4 internal cache).
Also, I don't understand why this message is only an INFO message, and not a WARN (pr_warn()). Please let me know if you have good reasons to keep it as an unconditional pr_info()
Making it conditional (__GFP_NOWARN based what you already have) with pr_warn() message makes more sense.