Hi Christian,
On Tue, 16 Feb 2016 21:33:51 +0100, Christian König wrote:
At least for Radeon and Amdgpu the current situation is actually what we want.
However I still find it confusing that full userptr support is under #if defined(CONFIG_MMU_NOTIFIER), and not under #if defined(CONFIG_RADEON_USERPTR), resp. #if defined(CONFIG_AMDGPU_USERPTR). It means that full userptr support may be included even if these options are disabled.
Which is perfectly fine. Userptr support should be enabled when MMU_NOTIFIER is available.
How this becomes available is a different story. You can explicitly enable it which then pulls in the MMU_NOTIFIER dependency or you just enable it when you have the notfier anyway because of some other dependency.
Again, how is this any better than just selecting MMU_NOTIFIER unconditionally?
The proliferation of kconfig options is not helping.
That we have two options doing the same is just a matter of branching of amdgpu from radeon and not cleaning up the configuration options. So feel free to cleaning this up and write a patch which makes pulling in MMU_NOTIFIER as a general DRM option.