On Thu, Nov 12, 2015 at 06:52:20PM +0200, ville.syrjala@linux.intel.com wrote:
From: Ville Syrjälä ville.syrjala@linux.intel.com
I got sick and tired of staring at the line noise produced by drm.debug=0x1e, so I decided to give the crtcs and planes human readable names. Each driver can give whatever names it wants, and for i915 I gave something that makes some sense w.r.t. to the spec.
The only magic gotcha here is that if the driver dynamically allocates the name, it must be careful around drm_{crtc,plane}_cleanup() cause those guys just memset the entire structure to 0. I didn't want to put the kfree() into the cleanup functions to avoid having to kstrdup("") in the fallback case or forcing drivers to always use a dynamic allocation.
I avoiding the kstrdup("") is a bit a hack, especially since we could put somethinig useful in there like "idx-%i", drm_plane_index(). The index is used by a bunch of things (both internally and in ioctl structs), so pretty handy. -Daniel
Ville Syrjälä (6): drm: Add crtc->name and use it in debug messages drm: Add plane->name and use it in debug prints drm/i915: Use crtc->name in debug messages drm/i915: Use plane->name in debug prints drm/i915: Set crtc->name to "pipe A", "pipe B", etc. drm/i915: Give meaningful names to all the planes
drivers/gpu/drm/drm_atomic.c | 53 ++++++++------- drivers/gpu/drm/drm_atomic_helper.c | 60 +++++++++-------- drivers/gpu/drm/drm_crtc.c | 11 ++- drivers/gpu/drm/drm_crtc_helper.c | 24 ++++--- drivers/gpu/drm/i915/intel_display.c | 127 +++++++++++++++++++++++------------ drivers/gpu/drm/i915/intel_fbdev.c | 5 +- drivers/gpu/drm/i915/intel_sprite.c | 14 ++++ include/drm/drm_crtc.h | 4 ++ 8 files changed, 185 insertions(+), 113 deletions(-)
-- 2.4.10
dri-devel mailing list dri-devel@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/dri-devel