Re: [PATCH 07/15] drm/atomic-helper: make drm_gem_plane_helper_prepare_fb the default

Hi Daniel,

...

...

   * equivalent functionality should be implemented through private
   * members in the plane structure.
   *

•  * Drivers which always have their buffers pinned should use
  

•  * drm_gem_plane_helper_prepare_fb() for this hook.
  

•  * For GEM drivers who neither have a @prepare_fb not @cleanup_fb hook
  

s/not/nor/ ??

Yup.

...

...

•  * set drm_gem_plane_helper_prepare_fb() is called automatically to
  

          ^add comma?

...

•  * implement this.
  

Leave cleanup_fb out of the description to make it more readable.

With the not->nor typo fixed, why does this make it more readable? Afaiui neither ... nor ... is fairly standard English, and I really want to make this the default only if you specify absolutely no plane fb handling of your own.

What I tried to suggest was like this:

" Drivers which always have their buffers pinned should use drm_gem_plane_helper_prepare_fb() for this hook. For GEM drivers who do not have a @prepare_fb hook set, drm_gem_plane_helper_prepare_fb() is called automatically to implement this. "

But anyway is fine and with the typo fixed: Acked-by: Sam Ravnborg sam@ravnborg.org

Sam