Hi Paul,
Am 02.03.2020 um 20:10 schrieb Paul Cercueil paul@crapouillou.net:
Hi Nikolaus,
Le ven., févr. 28, 2020 at 19:19, H. Nikolaus Schaller hns@goldelico.com a écrit :
From: Sam Ravnborg sam@ravnborg.org Add DT bindings for the LCD controller on the jz4780 SoC Based on .txt binding from Zubair Lutfullah Kakakhel
If you mean Documentation/devicetree/bindings/display/ingenic,lcd.txt then it was written by me.
Ah, ok. We didn't recognise this before. 6 eyes see more than 4...
I just did cherry-pick this old 4.0 patch from 2015 by Zubair and it created a ingenic-jz4780-lcd.txt:
https://lore.kernel.org/patchwork/patch/547872/
and Sam was so kind to convert it to yaml.
Signed-off-by: Sam Ravnborg sam@ravnborg.org Cc: Zubair Lutfullah Kakakhel Zubair.Kakakhel@imgtec.com Cc: H. Nikolaus Schaller hns@goldelico.com Cc: Rob Herring robh@kernel.org Cc: devicetree@vger.kernel.org
.../bindings/display/ingenic-jz4780-lcd.yaml | 78 +++++++++++++++++++ 1 file changed, 78 insertions(+) create mode 100644 Documentation/devicetree/bindings/display/ingenic-jz4780-lcd.yaml diff --git a/Documentation/devicetree/bindings/display/ingenic-jz4780-lcd.yaml b/Documentation/devicetree/bindings/display/ingenic-jz4780-lcd.yaml new file mode 100644 index 000000000000..c71415a3a342 --- /dev/null +++ b/Documentation/devicetree/bindings/display/ingenic-jz4780-lcd.yaml @@ -0,0 +1,78 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/ingenic-jz4780-lcd.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml#
+title: Bindings for Ingenic JZ4780 LCD Controller
+maintainers:
- Zubair Lutfullah Kakakhel Zubair.Kakakhel@imgtec.com
- H. Nikolaus Schaller hns@goldelico.com
I'm the author of the driver, please put me here; and remove Zubair, which 1. didn't touch the DRM driver at all, and 2. isn't working at ImgTec anymore.
Yes that is true.
Also, no need to put yourself here, unless you maintain the Ingenic DRM/KMS driver.
Agreed. That was suggested by Sam.
+description: |
- LCD Controller is the Display Controller for the Ingenic JZ4780 SoC
+properties:
You should add a '$nodename' property.
- compatible:
- items:
- const: ingenic,jz4780-lcdThe .txt lists more compatible strings. Please add them all.
- reg:
- maxItems: 1
- description: the address & size of the LCD controller registers
Drop the description here,
- interrupts:
- maxItems: 1
- description: Specifies the interrupt provided by parent
and here.
- clocks:
- maxItems: 2
- description: Clock specifiers for the JZ4780_CLK_TVE JZ4780_CLK_LCD0PIXCLK
Add one 'description:' per item.
- clock-names:
- items:
- const: lcd_clk- const: lcd_pixclk- port:
- type: object
- description: |
A port node with endpoint definitions as defined inDocumentation/devicetree/bindings/media/video-interfaces.txt+required:
- compatible
- reg
- interrupts
- clocks
- clock-names
- port
+additionalProperties: false
+examples:
- |
- #include <dt-bindings/clock/jz4780-cgu.h>
- lcd: jz4780-lcdk@0x13050000 {
The node name does not comply with the DT spec, it should be 'lcd-controller'.
Ok, I think I'll review all so that it does match/replace Documentation/devicetree/bindings/display/ingenic,lcd.txt and no information is lost.
Cheers, -Paul
BR and thanks, Nikolaus